Fix up getDisplayField() in relation to Cake 6.0#1037
Merged
dereuromark merged 1 commit into3.nextfrom May 13, 2025
Merged
Conversation
dereuromark
force-pushed
the
3.next-display-field
branch
from
f99b656 to
2e8a083
Compare
Member
|
What's going on with the failing tests? |
Member
Author
|
Thats us waiting for your core Patch:) |
dereuromark
force-pushed
the
3.next-display-field
branch
from
2e8a083 to
efdc115
Compare
dereuromark
force-pushed
the
3.next-display-field
branch
from
efdc115 to
f4fc27d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that Bake is a debug/local tool only, and that this method would rarely be overwritten/extended, this should be safe to do in a satellite plugin like this.
Refs cakephp/cakephp#18338
It is impossible to be null anyway.